DEPR: method, limit, fill_axis keywords in align #51968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Mar 15, 2023
| @@ -9355,15 +9355,23 @@ def align( | |||
| - pad / ffill: propagate last valid observation forward to next valid. | |||
| - backfill / bfill: use NEXT valid observation to fill gap. | |||
|
|
|||
| .. deprecated:: 2.1 | |||
|
|
|||
| limit : int, default None | |||
There was a problem hiding this comment.
Should we change the defaults to lib.no_default? (for all keywords)
There was a problem hiding this comment.
i guess thatd be harmless, OK
There was a problem hiding this comment.
good call here, we had a few places where we explicitly passed method=None that werent caught in the previous version.
want to weigh in on broadcast_axis in #51856?
phofl
approved these changes
Mar 16, 2023
|
thx @jbrockmendel |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.xref #51856, closes if we decide we don't want to deprecate broadcast_axis